fix(core): Properly release and reclaim memory when stopping emulation

Collecting commented

2026-01-09 04:41:43 -05:00

Collaborator

This implements a more aggressive memory reclamation strategy when stopping emulation to prevent memory bloat and leaks. The entire purpose is to, instead of waiting for the Operating System to hitch & try to fix the issue itself with trying to reallocate RAM around, we free it immediately after the emulation stops, allowing users to have longer playtimes, and less worry about out-of-memory killers.

I've added a memory audit to ShutdownMainProcess that tracks the process RSS before and after shutdown. To actually give memory back to the OS, we now use MADV_DONTNEED (Linux) and MEM_RESET (Windows) on the device memory buffer, along with calling malloc_trim on Linux.

The Vulkan rasterizer now explicitly nukes its memory allocations, staging pools, and runtimes during destruction. This ensures all VkBuffer and VkImage handles are gone before the underlying memory slabs are freed.

Other changes:

Fixed a double-free crash in HostMemory by letting the unique_ptr handle cleanup automatically.
Reorganized the shutdown sequence to reset major systems (GPU, FS controller, etc.) before destroying the ServiceManager.
Updated Initialize and ReinitializeIfNecessary to handle memory layout changes and avoid redundant allocations.

This implements a more aggressive memory reclamation strategy when stopping emulation to prevent memory bloat and leaks. The entire purpose is to, instead of waiting for the Operating System to hitch & try to fix the issue itself with trying to reallocate RAM around, we free it immediately after the emulation stops, allowing users to have longer playtimes, and less worry about out-of-memory killers. I've added a memory audit to ShutdownMainProcess that tracks the process RSS before and after shutdown. To actually give memory back to the OS, we now use MADV_DONTNEED (Linux) and MEM_RESET (Windows) on the device memory buffer, along with calling malloc_trim on Linux. The Vulkan rasterizer now explicitly nukes its memory allocations, staging pools, and runtimes during destruction. This ensures all VkBuffer and VkImage handles are gone before the underlying memory slabs are freed. Other changes: 1. Fixed a double-free crash in HostMemory by letting the unique_ptr handle cleanup automatically. 2. Reorganized the shutdown sequence to reset major systems (GPU, FS controller, etc.) before destroying the ServiceManager. 3. Updated Initialize and ReinitializeIfNecessary to handle memory layout changes and avoid redundant allocations.

Collecting added 9 commits

2026-01-09 04:41:43 -05:00

fix(core): Properly release memory when stopping emulation e731bb0ba1

Signed-off-by: Collecting <[email protected]>

fix(core): Properly release memory when stopping emulation b3aefed75b

Signed-off-by: Collecting <[email protected]>

fix(core): Properly release memory when stopping emulation 24fe7ed36e

Signed-off-by: Collecting <[email protected]>

fix(core): Properly release memory when stopping emulation 5a28f13c06

Signed-off-by: Collecting <[email protected]>

fix(core): Properly release memory when stopping emulation a5a6ed7f37

Signed-off-by: Collecting <[email protected]>

fix(core): Properly release memory when stopping emulation e324c5b10f

Signed-off-by: Collecting <[email protected]>

fix(core): Properly release memory when stopping emulation e150d1e910

Signed-off-by: Collecting <[email protected]>

fix(core): Properly release memory when stopping emulation 1a8e019e36

Signed-off-by: Collecting <[email protected]>

fix(msvc/android): Compiler Errors for core.cpp 64a2e656f6

Signed-off-by: Collecting <[email protected]>

Collecting merged commit 574710f573 into main

2026-01-09 04:42:05 -05:00

Collecting deleted branch fix/memory-allocation

2026-01-09 04:42:06 -05:00

Collecting referenced this pull request from a commit

2026-01-09 04:42:07 -05:00

Merge pull request 'fix(core): Properly release and reclaim memory when stopping emulation' (#90) from fix/memory-allocation into main

Rows
Columns

fix(core): Properly release and reclaim memory when stopping emulation #90